feat(AggLayer): Solidity compatibility tests for MMR frontier code #2312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
into leaf<>root<>count paris; and canonical zeros
mmagician
commented
Jan 19, 2026
crates/miden-agglayer/solidity-compat/test/MMRTestVectors.t.sol
Outdated
Show resolved
Hide resolved
crates/miden-agglayer/solidity-compat/test/MMRTestVectors.t.sol
Outdated
Show resolved
Hide resolved
crates/miden-agglayer/solidity-compat/test/MMRTestVectors.t.sol
Outdated
Show resolved
Hide resolved
partylikeits1983
requested changes
Jan 20, 2026
Contributor
partylikeits1983
left a comment
partylikeits1983
left a comment
There was a problem hiding this comment.
Looks great! Only comment is to remove console.log()s from tests & to use foundry cheatcode instead of doing string manipulation in solidity :)
PhilippGackstatter
approved these changes
Jan 20, 2026
Contributor
PhilippGackstatter
left a comment
PhilippGackstatter
left a comment
There was a problem hiding this comment.
Looks good to me! I reviewed the structure and the Rust tests, but can't comment too much on Solidity code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested here, we're getting to a stage with the AggLayer integration where we should check for compatibility with the Solidity implementation.
This PR adds a small foundry project inside the
miden-agglayercrate:forgecommands to generate the test vectors. The vectors are generated by calling the Solidity functions of interest_addLeaf&getRootmake generate-solidity-test-vectorscommand to locally re-generate the test filesKeccakMmrFrontier32(currently we're not comparing with the output of MASM, since we independently already have Rust<>MASM compatibility test, so by extension we have Solidity<>MASM compat)To be done in a follow-up PR:
miden-testing/agglayercode intomiden-agglayercrate. Otherwise, the Rust compat test (located inmiden-testingdepends on the test vectors which are generated in a different crate (miden-agglayer)